Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: externalize all wire links to support custom builds (WPB-9811) 🍒 🍒 #3165

Merged
merged 3 commits into from
Jul 8, 2024
Merged

chore: externalize all wire links to support custom builds (WPB-9811) 🍒 🍒 #3165

merged 3 commits into from
Jul 8, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 5, 2024 •
edited
Loading

BugWPB-9811 [Android] - C1, C2, C3 related Links are outdated- add new links as below - on Custom builds

This PR was automatically cherry-picked based on the following PR:

Original PR description:

This PR was automatically cherry-picked based on the following PR:

Original PR description:

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

For custom builds, we need to support external URLs not necessary into the wire website.

Causes (Optional)

Not supported / Out of initial scope

Solutions

  • Move URLs to urls.xml file, so external builds can have their own if necessary.
  • Fixes some URLs that were localized, this is not necessary since wire portal handles this according to the browser locale.

Note

Most of the changes are removing entries from strings resources, this can be ignored to have a better review.

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch size/L labels Jul 5, 2024
@pull-request-size pull-request-size bot added size/XL and removed size/L labels Jul 5, 2024
@pull-request-size Pull Request Size
Copy link

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@yamilmedina yamilmedina requested review from yamilmedina, a team, typfel, borichellow, vitorhugods and Garzas and removed request for a team July 8, 2024 08:47
vitorhugods
vitorhugods reviewed Jul 8, 2024
View reviewed changes
app/lint-baseline.xml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow

@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Jul 8, 2024

Built wire-android-staging-compat-pr-3165.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Jul 8, 2024

Built wire-android-dev-debug-pr-3165.apk is available for download

@yamilmedina yamilmedina added this pull request to the merge queue Jul 8, 2024
Merged via the queue into develop with commit 9bb37df Jul 8, 2024
10 of 11 checks passed
@yamilmedina yamilmedina deleted the chore/links-for-custombuilds-cherry-pick-cherry-pick branch July 8, 2024 10:18
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Jul 16, 2024
@b1pb1p b1pb1p removed the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Jul 18, 2024
@b1pb1p b1pb1p added echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. labels Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitorhugods vitorhugods vitorhugods approved these changes

@alexandreferris alexandreferris alexandreferris approved these changes

@yamilmedina yamilmedina yamilmedina approved these changes

@typfel typfel Awaiting requested review from typfel typfel was automatically assigned from wireapp/android

@borichellow borichellow Awaiting requested review from borichellow borichellow was automatically assigned from wireapp/android

@Garzas Garzas Awaiting requested review from Garzas Garzas was automatically assigned from wireapp/android

Assignees

@yamilmedina yamilmedina

Labels
cherry-pick PR is cherry-picking changes from another banch echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yamilmedina @alexandreferris @vitorhugods @b1pb1p