Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Shields not shown in group participants list [WPB-10255] 🍒 #3276

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 2, 2024

BugWPB-10255 [Android] Shields not shown anymore on group participants list

This PR was automatically cherry-picked based on the following PR:

Original PR description:


What's new in this PR?

Issues

In group participance screen: green shields (E2EI verification) are not shown anymore

Causes (Optional)

Small "if null" mistake in mapping E2EI into "is verified" boolean.

Solutions

Fix it and add tests to cover that case

@github-actions github-actions bot added echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/XS labels Aug 2, 2024
Copy link

sonarqubecloud bot commented Aug 5, 2024

@alexandreferris alexandreferris added this pull request to the merge queue Aug 5, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 44.56%. Comparing base (d746711) to head (96a9bd8).

Files Patch % Lines
...ecase/ObserveParticipantsForConversationUseCase.kt 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3276      +/-   ##
=====================================================
- Coverage              44.57%   44.56%   -0.01%     
=====================================================
  Files                    453      453              
  Lines                  15192    15192              
  Branches                2523     2525       +2     
=====================================================
- Hits                    6772     6771       -1     
- Misses                  7702     7703       +1     
  Partials                 718      718              
Files Coverage Δ
...ecase/ObserveParticipantsForConversationUseCase.kt 88.63% <50.00%> (-2.28%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d746711...96a9bd8. Read the comment docs.

Merged via the queue into release/candidate with commit fedb66d Aug 5, 2024
11 of 12 checks passed
@alexandreferris alexandreferris deleted the fix/shields_not_shown_in_group_participants_list-cherry-pick branch August 5, 2024 14:15
Copy link
Contributor Author

github-actions bot commented Aug 5, 2024

Built wire-android-staging-compat-pr-3276.apk is available for download

Copy link
Contributor Author

github-actions bot commented Aug 5, 2024

Built wire-android-internal-compat-pr-3276.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants