fix: multiline topbar title still sometimes not centered [WPB-9608] 🍒 #3282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
cherry-pick
saleniuk
requested review from
a team,
typfel,
yamilmedina,
alexandreferris,
Garzas and
ohassine
and removed request for
a team
|
Built wire-android-staging-compat-pr-3282.apk is available for download |
|
Built wire-android-dev-debug-pr-3282.apk is available for download |
MohamadJaara
approved these changes
Aug 5, 2024
|
|
Built wire-android-staging-compat-pr-3282.apk is available for download |
|
Built wire-android-dev-debug-pr-3282.apk is available for download |
ohassine
approved these changes
Aug 6, 2024
ohassine
deleted the
fix/topbar-title-centered-with-paddings-cherry-pick
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
It's a follow up to this PR #3239 to also fix one edge case.
Issues
The title is not centered for some specific title text lenghts.
Causes (Optional)
Text lines lengths was being calculated without taking paddings into account, so in some specific cases it could still be not centered - if the text without paddings (we use 6.dp) would fit in one line but with paddings included it would need to be splitted into two lines.
Solutions
Move paddings to the parent box so that calculated text constraints and actual Text composable widths are exactly the same.
Title for one of previews is modified to also be just long enough to fall into this edge case.
Testing
How to Test
On some devices the name created from the emulator "google sdk_gphone64_arm64 [beta_debug]" was just long enough to fall into this edge case.
Attachments (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.