-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: connection button not shown when partial metadata (WPB-10342) 🍒 #3284
Conversation
…3280) Co-authored-by: Mojtaba Chenani <[email protected]>
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3284 +/- ##
===========================================
+ Coverage 44.54% 44.55% +0.01%
===========================================
Files 453 453
Lines 15194 15198 +4
Branches 2526 2527 +1
===========================================
+ Hits 6768 6772 +4
Misses 7708 7708
Partials 718 718
Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3284.apk is available for download |
Built wire-android-dev-debug-pr-3284.apk is available for download |
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
There might be cases that metadata is incomplete (username or handle)
Causes (Optional)
We hide the action buttons for connection requests.
Solutions
expiresAt
mapping, so we also handle connection/role edition for temporary users.Testing
Test Coverage (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.