Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve audio file size [WPB-10001] 🍒 #3290

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 6, 2024

TaskWPB-10001 [Android] Reduce the file recording file size

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Files saved in wav format are pretty big. So we decided to encode it with or without filters on wav but before sending convert with AAC encoding and decrease SAMPLING_RATE to 16k

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch size/S labels Aug 6, 2024
Copy link

sonarqubecloud bot commented Aug 6, 2024

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 2.80374% with 104 lines in your changes missing coverage. Please review.

Project coverage is 44.28%. Comparing base (2be01ab) to head (24e6971).
Report is 1 commits behind head on develop.

Files Patch % Lines
.../messagecomposer/recordaudio/AudioMediaRecorder.kt 0.00% 79 Missing ⚠️
...essagecomposer/recordaudio/RecordAudioViewModel.kt 0.00% 24 Missing ⚠️
.../conversations/sendmessage/SendMessageViewModel.kt 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3290      +/-   ##
===========================================
- Coverage    44.55%   44.28%   -0.27%     
===========================================
  Files          453      453              
  Lines        15198    15288      +90     
  Branches      2529     2554      +25     
===========================================
  Hits          6771     6771              
- Misses        7709     7799      +90     
  Partials       718      718              
Files Coverage Δ
...android/ui/home/conversations/model/AssetBundle.kt 45.45% <100.00%> (+2.59%) ⬆️
...recordaudio/GenerateAudioFileWithEffectsUseCase.kt 6.25% <ø> (ø)
.../conversations/sendmessage/SendMessageViewModel.kt 79.08% <50.00%> (+0.29%) ⬆️
...essagecomposer/recordaudio/RecordAudioViewModel.kt 60.26% <0.00%> (-5.21%) ⬇️
.../messagecomposer/recordaudio/AudioMediaRecorder.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2be01ab...24e6971. Read the comment docs.

@Garzas Garzas added this pull request to the merge queue Aug 6, 2024
Copy link
Contributor Author

github-actions bot commented Aug 6, 2024

Built wire-android-staging-compat-pr-3290.apk is available for download

Copy link
Contributor Author

github-actions bot commented Aug 6, 2024

Built wire-android-dev-debug-pr-3290.apk is available for download

Merged via the queue into develop with commit addf55a Aug 6, 2024
11 of 12 checks passed
@Garzas Garzas deleted the fix/improve-audio-file-size-cherry-pick branch August 6, 2024 11:10
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants