-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Do not send data to Analytics on custom backend (WPB-10020) 🍒 #3295
chore: Do not send data to Analytics on custom backend (WPB-10020) 🍒 #3295
Conversation
…3294) Signed-off-by: alexandreferris <[email protected]>
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3295 +/- ##
========================================
Coverage 44.41% 44.42%
========================================
Files 453 453
Lines 15304 15308 +4
Branches 2556 2558 +2
========================================
+ Hits 6798 6801 +3
- Misses 7790 7791 +1
Partials 716 716
Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3295.apk is available for download |
Built wire-android-dev-debug-pr-3295.apk is available for download |
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
We were sending analytics to custom backends (and not only prod)
Causes (Optional)
No verification was implemented
Solutions
Add verification of current API URL and verify agains PROD API URL so ignoring any other custom backend (staging included).
Testing
Test Coverage (Optional)
How to Test
-- Test 1
-- Test 2