Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: create 'beta' builds for nightly tests suite (WPB-10408) #3296

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Aug 7, 2024

TaskWPB-10408 [Android] Enable QA again to access release builds for nightly runs


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

QA can not run anymore, 'nightly' runs, since the migration to gh actions.

Causes (Optional)

We changed the flavors built, and they cannot differentiate between the ones coming from develop and release/candidate

Solutions

Create "beta" (staging release) for pushes on release candidate only.

Notes


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.75%. Comparing base (14e21fa) to head (6bf36c7).

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/candidate    #3296   +/-   ##
==================================================
  Coverage              44.75%   44.75%           
==================================================
  Files                    456      456           
  Lines                  15374    15374           
  Branches                2565     2565           
==================================================
  Hits                    6880     6880           
  Misses                  7772     7772           
  Partials                 722      722           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14e21fa...6bf36c7. Read the comment docs.

Copy link
Contributor

github-actions bot commented Aug 7, 2024

Built wire-android-staging-compat-pr-3296.apk is available for download

Copy link
Contributor

github-actions bot commented Aug 7, 2024

Built wire-android-internal-compat-pr-3296.apk is available for download

Copy link
Contributor

github-actions bot commented Aug 9, 2024

Built wire-android-staging-compat-pr-3296.apk is available for download

Copy link
Contributor

github-actions bot commented Aug 9, 2024

Built wire-android-internal-compat-pr-3296.apk is available for download

@yamilmedina yamilmedina marked this pull request as ready for review August 13, 2024 13:35
@yamilmedina yamilmedina requested review from CinnamonNinja, a team, typfel, alexandreferris, borichellow, MohamadJaara and ohassine and removed request for a team August 13, 2024 13:35
Copy link

Copy link
Contributor

Built wire-android-staging-compat-pr-3296.apk is available for download

Copy link
Contributor

Built wire-android-internal-compat-pr-3296.apk is available for download

@yamilmedina yamilmedina added this pull request to the merge queue Aug 13, 2024
Merged via the queue into release/candidate with commit 2e4fcd4 Aug 13, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants