fix: Remove Reset Session for MLS conversations [WPB-10426] 🍒 🍒 #3309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: boris <[email protected]>
github-actions
bot
added
cherry-pick
borichellow
approved these changes
Aug 13, 2024
alexandreferris
approved these changes
Aug 13, 2024
…tions-cherry-pick-cherry-pick
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3309 +/- ##
===========================================
+ Coverage 44.51% 44.54% +0.02%
===========================================
Files 453 453
Lines 15335 15341 +6
Branches 2560 2560
===========================================
+ Hits 6827 6833 +6
Misses 7791 7791
Partials 717 717
Continue to review full report in Codecov by Sentry.
|
|
Built wire-android-staging-compat-pr-3309.apk is available for download |
|
Built wire-android-dev-debug-pr-3309.apk is available for download |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
MohamadJaara
deleted the
fix/remove_reset_session_for_mls_conversations-cherry-pick-cherry-pick
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
This PR was automatically cherry-picked based on the following PR:
Original PR description:
What's new in this PR?
Issues
When we receive decryption errors in an MLS conversation, we show a “reset session” button.
But this button does not help to reset the session and is useless.
Therefore, we should hide it and not show it to the user.
Causes (Optional)
Nobody think about differences in MLS conversations :)
Solutions
Think about it and remove "Reset Session" btn and text "Try resetting the session ..." text