-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove direct usage of Lazy<CoreLogic> (WPB-10304) #3311
fix: Remove direct usage of Lazy<CoreLogic> (WPB-10304) #3311
Conversation
Signed-off-by: alexandreferris <[email protected]>
Signed-off-by: alexandreferris <[email protected]>
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3311 +/- ##
==================================================
Coverage 44.67% 44.67%
==================================================
Files 456 456
Lines 15361 15361
Branches 2560 2560
==================================================
Hits 6862 6862
Misses 7780 7780
Partials 719 719
Continue to review full report in Codecov by Sentry.
|
Signed-off-by: alexandreferris <[email protected]>
Built wire-android-staging-compat-pr-3311.apk is available for download |
Built wire-android-internal-compat-pr-3311.apk is available for download |
Signed-off-by: alexandreferris <[email protected]> (cherry picked from commit 443db9d)
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Crash is still happening
Solutions
Raise now approach n#2 of removing
Lazy<>
fromLazy<CoreLogic>
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.