Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Set analytics enabled for beta builds (WPB-10293) #3316

Merged
merged 1 commit into from
Aug 13, 2024
Merged

chore: Set analytics enabled for beta builds (WPB-10293) #3316

merged 1 commit into from
Aug 13, 2024

Conversation

alexandreferris
Copy link
Contributor

@alexandreferris alexandreferris commented Aug 13, 2024 •
edited by github-actions bot
Loading

TaskWPB-10293 [Android] disable countly

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We needed analytics enable on beta builds to be tested

Solutions

Set analytics enabled flag to true only on beta builds

@alexandreferris alexandreferris self-assigned this Aug 13, 2024
@alexandreferris alexandreferris requested review from a team, borichellow, vitorhugods, mchenani, Garzas, saleniuk, yamilmedina and MohamadJaara and removed request for a team August 13, 2024 08:33
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@alexandreferris alexandreferris added this pull request to the merge queue Aug 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3316.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-internal-compat-pr-3316.apk is available for download

Merged via the queue into release/candidate with commit a7d70de Aug 13, 2024
13 checks passed
@alexandreferris alexandreferris deleted the chore/set_analytics_enabled_for_beta_builds branch August 13, 2024 09:37
github-actions bot pushed a commit that referenced this pull request Aug 13, 2024
@alexandreferris @github-actions
chore: Set analytics enabled for beta builds (WPB-10293) (#3316)
f6ef954 
Signed-off-by: alexandreferris <[email protected]>
@github-actions github-actions bot mentioned this pull request Aug 13, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitorhugods vitorhugods vitorhugods approved these changes

@MohamadJaara MohamadJaara MohamadJaara approved these changes

@borichellow borichellow Awaiting requested review from borichellow borichellow was automatically assigned from wireapp/android

@mchenani mchenani Awaiting requested review from mchenani mchenani was automatically assigned from wireapp/android

@Garzas Garzas Awaiting requested review from Garzas Garzas was automatically assigned from wireapp/android

@saleniuk saleniuk Awaiting requested review from saleniuk saleniuk was automatically assigned from wireapp/android

@yamilmedina yamilmedina Awaiting requested review from yamilmedina

Assignees

@alexandreferris alexandreferris

Labels
echoes/initiative: product-metrics-in-countly Analytics and KPIs size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandreferris @MohamadJaara @vitorhugods