-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: handle temporary guest users details (WPB-10454) #3322
Conversation
New ADR(s) in this PR 📚:3. Use parameterizable tests in JUnit5Date: 2024-08-05 StatusAccepted ContextSometimes we need to write multiple tests for the same scenario, changing only the input values. DecisionWe will use parameterizable tests in JUnit5 to avoid writing multiple tests for the same scenario. Consequences
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3322 +/- ##
========================================
Coverage 44.61% 44.62%
========================================
Files 456 456
Lines 15380 15382 +2
Branches 2563 2564 +1
========================================
+ Hits 6862 6864 +2
Misses 7798 7798
Partials 720 720
Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3322.apk is available for download |
Built wire-android-dev-debug-pr-3322.apk is available for download |
Built wire-android-staging-compat-pr-3322.apk is available for download |
Built wire-android-dev-debug-pr-3322.apk is available for download |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work!
I just have one question but not a blocker, mostly curious hehe
app/src/main/kotlin/com/wire/android/ui/userprofile/common/UserProfileInfo.kt
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
Built wire-android-staging-compat-pr-3322.apk is available for download |
Built wire-android-dev-debug-pr-3322.apk is available for download |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
We don't have handling for temporary users
Causes (Optional)
Not implemented
Solutions
Implement the handling for temporary users; avatar, handle, etc.
Testing
Test Coverage (Optional)
How to Test
Join a conversation as a guest user, you should see indicators about; time left, avatar with indicator.
Notes
Unrelated changes:
Attachments (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.