Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve Analytics dialog (WPB-10601) #3336

Merged
merged 5 commits into from
Aug 19, 2024

Conversation

alexandreferris
Copy link
Contributor

@alexandreferris alexandreferris commented Aug 16, 2024

TaskWPB-10601 [Android] Make countly dialogue not dismissible


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  • Dialog is dismissable
  • Text copy was updated

Solutions

  • Remove the possibility to dismiss the dialog without properly selecting a action button.
  • Update text copy of dialog
  • rename variable naming (previously added staging to valid backend verification)

Dependencies (Optional)

Testing

How to Test

  • Fresh login with analytics enabled in build level
  • dialog is shown and is not dismissible

Attachments (Optional)

Dialog Toggle

Signed-off-by: alexandreferris <ferris.alexandre@gmail.com>
Signed-off-by: alexandreferris <ferris.alexandre@gmail.com>
Signed-off-by: alexandreferris <ferris.alexandre@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.74%. Comparing base (a404cdf) to head (0ac1914).
Report is 5 commits behind head on release/candidate.

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/candidate    #3336   +/-   ##
==================================================
  Coverage              44.74%   44.74%           
==================================================
  Files                    456      456           
  Lines                  15396    15396           
  Branches                2573     2573           
==================================================
  Hits                    6889     6889           
  Misses                  7780     7780           
  Partials                 727      727           
Files Coverage Δ
...re/android/ui/analytics/AnalyticsUsageViewModel.kt 93.10% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a404cdf...0ac1914. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3336.apk is available for download

Copy link
Contributor

Built wire-android-internal-compat-pr-3336.apk is available for download

@alexandreferris alexandreferris added DO NOT MERGE WIP Work In Progress labels Aug 19, 2024
Signed-off-by: alexandreferris <ferris.alexandre@gmail.com>
Signed-off-by: alexandreferris <ferris.alexandre@gmail.com>
@alexandreferris alexandreferris removed WIP Work In Progress DO NOT MERGE labels Aug 19, 2024
Copy link

@alexandreferris alexandreferris added this pull request to the merge queue Aug 19, 2024
Merged via the queue into release/candidate with commit fcacb24 Aug 19, 2024
12 of 13 checks passed
@alexandreferris alexandreferris deleted the chore/improve_analytics_dialog branch August 19, 2024 08:52
github-actions bot pushed a commit that referenced this pull request Aug 19, 2024
Signed-off-by: alexandreferris <ferris.alexandre@gmail.com>
Copy link
Contributor

Built wire-android-staging-compat-pr-3336.apk is available for download

Copy link
Contributor

Built wire-android-internal-compat-pr-3336.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants