Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: time not displayed correctly on Samsung devices [WPB-10598] #3359

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Aug 22, 2024

BugWPB-10598 [Android] Timestamps not displayed correctly on samsung devices


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

time not displayed correctly on samsung devices

Causes (Optional)

the date time formater used does not recpect the local settings on samsung devices

Solutions

replace it with java.time api

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Aug 22, 2024
Copy link

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.74%. Comparing base (305ae7a) to head (e4a3350).
Report is 1 commits behind head on release/candidate.

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/candidate    #3359   +/-   ##
==================================================
  Coverage              44.73%   44.74%           
==================================================
  Files                    456      456           
  Lines                  15398    15401    +3     
  Branches                2574     2572    -2     
==================================================
+ Hits                    6889     6891    +2     
- Misses                  7782     7783    +1     
  Partials                 727      727           
Files Coverage Δ
...kotlin/com/wire/android/util/DateAndTimeParsers.kt 76.08% <100.00%> (-0.66%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 305ae7a...e4a3350. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3359.apk is available for download

@MohamadJaara MohamadJaara changed the title fix: time not displayed correctly on samsung devices fix: time not displayed correctly on Samsung devices [WPB-10598] Aug 22, 2024
Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on the device with wrong formats, and works 🚀

@MohamadJaara MohamadJaara added this pull request to the merge queue Aug 23, 2024
Merged via the queue into release/candidate with commit a7c08b0 Aug 23, 2024
15 of 16 checks passed
@MohamadJaara MohamadJaara deleted the fix/WPB-10598 branch August 23, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants