Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing staging backend verification for analytics (WPB-10736) #3366

Conversation

alexandreferris
Copy link
Contributor

@alexandreferris alexandreferris commented Aug 23, 2024

BugWPB-10736 [Android] Analytics enabled shows false for users on staging, after they agreed to share data

…ifier


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

There was no verification for staging backend api when observing analytics toggle change

Causes (Optional)

Missed out this part

Solutions

Add staging backend api when observing analytics toggle change to propagate identifier and initialize analytics

@alexandreferris alexandreferris self-assigned this Aug 23, 2024
@alexandreferris alexandreferris requested review from a team, typfel, yamilmedina, borichellow, vitorhugods and saleniuk and removed request for a team August 23, 2024 14:48
Signed-off-by: alexandreferris <[email protected]>
Copy link

@alexandreferris alexandreferris added this pull request to the merge queue Aug 23, 2024
Copy link
Contributor

Built wire-android-staging-compat-pr-3366.apk is available for download

Merged via the queue into release/candidate with commit 06346ef Aug 23, 2024
12 of 13 checks passed
@alexandreferris alexandreferris deleted the fix/add_missing_staging_backend_verification_for_analytics branch August 23, 2024 15:43
github-actions bot pushed a commit that referenced this pull request Aug 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.75%. Comparing base (29f877e) to head (94d121a).
Report is 25 commits behind head on release/candidate.

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/candidate    #3366   +/-   ##
==================================================
  Coverage              44.74%   44.75%           
==================================================
  Files                    456      456           
  Lines                  15401    15403    +2     
  Branches                2572     2574    +2     
==================================================
+ Hits                    6891     6893    +2     
  Misses                  7783     7783           
  Partials                 727      727           
Files with missing lines Coverage Δ
...analytics/ObserveCurrentSessionAnalyticsUseCase.kt 83.33% <100.00%> (+0.98%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29f877e...94d121a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants