fix: missing verification for analytics toggle (WPB-10587) 🍒 #3379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: alexandreferris <[email protected]>
github-actions
bot
added
cherry-pick
alexandreferris
approved these changes
Aug 27, 2024
|
alexandreferris
approved these changes
Aug 27, 2024
alexandreferris
requested review from
a team,
typfel,
yamilmedina,
borichellow,
MohamadJaara and
vitorhugods
and removed request for
a team
yamilmedina
approved these changes
Aug 27, 2024
|
Built wire-android-staging-compat-pr-3379.apk is available for download |
|
Built wire-android-dev-debug-pr-3379.apk is available for download |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
alexandreferris
deleted the
fix/missing_verification_for_analytics_toggle-cherry-pick
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
When on custom backends (different from PROD or STAGING) we were showing the analytics toggle in Privacy Settings Screen
Causes (Optional)
We had the verification already set but was not being used
Solutions
Use state attribute containing the value to show or hide the analytics toggle
Testing
How to Test