Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix apk path when uploading release apk to gh releases (WPB-8645) #3382

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Aug 27, 2024

EpicWPB-8645 [Android] Infrastructure code and developer experience


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

fix apk path when uploading release apk to gh releases


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-requested a review August 27, 2024 09:00
Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small typo

Copy link

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.75%. Comparing base (00b6633) to head (f60a9f1).
Report is 4 commits behind head on release/candidate.

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/candidate    #3382   +/-   ##
==================================================
  Coverage              44.75%   44.75%           
==================================================
  Files                    456      456           
  Lines                  15403    15403           
  Branches                2574     2574           
==================================================
  Hits                    6893     6893           
  Misses                  7783     7783           
  Partials                 727      727           

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00b6633...f60a9f1. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3382.apk is available for download

@MohamadJaara MohamadJaara enabled auto-merge August 27, 2024 10:14
@yamilmedina yamilmedina changed the title ci: fix apk path when uploading release apk to gh releases ci: fix apk path when uploading release apk to gh releases - no ticket Aug 27, 2024
@yamilmedina yamilmedina changed the title ci: fix apk path when uploading release apk to gh releases - no ticket ci: fix apk path when uploading release apk to gh releases (WPB-8645) Aug 27, 2024
@MohamadJaara MohamadJaara added this pull request to the merge queue Aug 27, 2024
Merged via the queue into release/candidate with commit 7f72679 Aug 27, 2024
15 of 17 checks passed
@MohamadJaara MohamadJaara deleted the ci/fix-play-store-upload-folder branch August 27, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants