Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update analytics dialog string (WPB-9973) 🍒 #3423

Merged
merged 2 commits into from
Sep 9, 2024
Merged

chore: update analytics dialog string (WPB-9973) 🍒 #3423

merged 2 commits into from
Sep 9, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 9, 2024

This PR was automatically cherry-picked based on the following PR:

Original PR description:

StoryWPB-9973 [Android] data collection for free users

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Wrong company naming on analytics dialog text

Solutions

Adjust string with latest copy

Testing

How to Test

  • Have a build with Analytics enabled
  • dialog is shown on fresh login and dialog copy is correct

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch echoes/initiative: product-metrics-in-countly Analytics and KPIs size/XS labels Sep 9, 2024
@alexandreferris alexandreferris requested review from a team, alexandreferris, vitorhugods, mchenani, Garzas and ohassine and removed request for a team September 9, 2024 09:23
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@alexandreferris alexandreferris added this pull request to the merge queue Sep 9, 2024
Merged via the queue into develop with commit 1097fc0 Sep 9, 2024
11 of 12 checks passed
@alexandreferris alexandreferris deleted the chore/update_analytics_dialog_string-cherry-pick branch September 9, 2024 10:01
@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Sep 9, 2024

Built wire-android-staging-compat-pr-3423.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Sep 9, 2024

Built wire-android-dev-debug-pr-3423.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitorhugods vitorhugods vitorhugods approved these changes

@alexandreferris alexandreferris alexandreferris approved these changes

@mchenani mchenani Awaiting requested review from mchenani mchenani was automatically assigned from wireapp/android

@Garzas Garzas Awaiting requested review from Garzas Garzas was automatically assigned from wireapp/android

@ohassine ohassine Awaiting requested review from ohassine ohassine was automatically assigned from wireapp/android

Assignees

@alexandreferris alexandreferris

Labels
cherry-pick PR is cherry-picking changes from another banch echoes/initiative: product-metrics-in-countly Analytics and KPIs size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandreferris @vitorhugods