fix: empty dependencies section [WPB-10929] #3425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into fix/empty-dependencies-section
echoes-hq
bot
added
the
echoes: unplanned
saleniuk
requested review from
a team,
typfel,
yamilmedina,
alexandreferris,
borichellow and
MohamadJaara
and removed request for
a team
Test Results863 tests 863 ✅ 28m 51s ⏱️ Results for commit 043f10b. ♻️ This comment has been updated with latest results. |
|
APKs built during tests are available here. Scroll down to Artifacts! |
app/src/main/kotlin/com/wire/android/ui/debug/DebugDataOptions.kt
Outdated
Show resolved
Hide resolved
|
MohamadJaara
approved these changes
Sep 10, 2024
alexandreferris
approved these changes
Sep 10, 2024
6 tasks
|
APKs built during tests are available here. Scroll down to Artifacts! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
App does not show dependency versions (core-crypto, avs).
Causes (Optional)
The string with dependencies is remembered to keep it during recompositions, but without any key and the dependencies map is empty initially, so when the proper data appears, it takes the remembered empty value instead of creating new proper one with dependencies.
Solutions
Use
dependenciesas a key when remembering string so that when dependencies change, the string is rebuilt with current data.Also,
DependenciesItemtexts stylings and paddings are unified with all other debug screen elements.Testing
How to Test
Open "Debug Settings" and check "Dependencies" section.
Attachments (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.