Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add analytics initial events (WPB-10589) #3428

Merged
merged 13 commits into from
Sep 12, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Sep 10, 2024

TaskWPB-10589 [Android] Implement events and segmentation as is on iOS


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Implement anonymous analytics for events contribution,

Causes (Optional)

Never implemented

Solutions

Implement the same as the other platforms were doing

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this Sep 10, 2024
@yamilmedina yamilmedina requested review from alexandreferris, a team, vitorhugods, mchenani, Garzas and ohassine and removed request for a team September 10, 2024 15:19
Copy link
Contributor

@alexandreferris alexandreferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍 added a note for other reviewers

Comment on lines +100 to +102

@Provides
fun provideAnonymousAnalyticsManager(): AnonymousAnalyticsManager = AnonymousAnalyticsManagerImpl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this is mostly to be injected in a VM so the manager can be used in tests

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 81.57895% with 7 lines in your changes missing coverage. Please review.

Project coverage is 44.84%. Comparing base (7646333) to head (9d6b2b3).
Report is 1 commits behind head on release/candidate.

Files with missing lines Patch % Lines
.../conversations/sendmessage/SendMessageViewModel.kt 83.33% 1 Missing and 4 partials ⚠️
.../home/settings/backup/BackupAndRestoreViewModel.kt 75.00% 2 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3428      +/-   ##
=====================================================
+ Coverage              44.75%   44.84%   +0.09%     
=====================================================
  Files                    456      456              
  Lines                  15404    15442      +38     
  Branches                2574     2582       +8     
=====================================================
+ Hits                    6894     6925      +31     
- Misses                  7783     7786       +3     
- Partials                 727      731       +4     
Files with missing lines Coverage Δ
...id/ui/home/conversationslist/ConversationRouter.kt 0.00% <ø> (ø)
.../home/settings/backup/BackupAndRestoreViewModel.kt 87.19% <75.00%> (-0.63%) ⬇️
.../conversations/sendmessage/SendMessageViewModel.kt 83.98% <83.33%> (-0.10%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7646333...9d6b2b3. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3428.apk is available for download

Copy link

Copy link
Contributor

Built wire-android-staging-compat-pr-3428.apk is available for download

@yamilmedina yamilmedina added this pull request to the merge queue Sep 12, 2024
Merged via the queue into release/candidate with commit 847a99f Sep 12, 2024
13 checks passed
@yamilmedina yamilmedina deleted the feat/add_analytics_initial_events branch September 12, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants