-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add analytics initial events (WPB-10589) #3428
feat: add analytics initial events (WPB-10589) #3428
Conversation
…e events Signed-off-by: alexandreferris <[email protected]>
Signed-off-by: alexandreferris <[email protected]>
Signed-off-by: alexandreferris <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍 added a note for other reviewers
|
||
@Provides | ||
fun provideAnonymousAnalyticsManager(): AnonymousAnalyticsManager = AnonymousAnalyticsManagerImpl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: this is mostly to be injected in a VM so the manager can be used in tests
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3428 +/- ##
=====================================================
+ Coverage 44.75% 44.84% +0.09%
=====================================================
Files 456 456
Lines 15404 15442 +38
Branches 2574 2582 +8
=====================================================
+ Hits 6894 6925 +31
- Misses 7783 7786 +3
- Partials 727 731 +4
Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3428.apk is available for download |
Quality Gate passedIssues Measures |
Built wire-android-staging-compat-pr-3428.apk is available for download |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Implement anonymous analytics for events contribution,
Causes (Optional)
Never implemented
Solutions
Implement the same as the other platforms were doing
Testing
Test Coverage (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.