fix: wrong service opens when clicking on search result [WPB-11330] #3476
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
When searching for a service and clicking on search result, wrong service opens.
Causes (Optional)
Items are not identified by any key, only by index and clickable is remembered without any key, so items can be reused with clickable remembered for other service.
Solutions
Use
folderWithElements
which is our common way of showing lists and it already enforces associating key to each item. Use remembered with a key for clickable.Testing
How to Test
STR:
-have multiple services in your team available (Wire prod has them)
-open any group where you are admin
-tap on “add participants” tab
-tap on “services”
-search for a service (e.g. “Echo”)
-tap on the found service
Expected: I should see the service I searched for
Attachments (Optional)
service_click_before.mp4
service_click_after.mp4
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.