Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update designs for QR button (WPB-10539) #3487

Merged
merged 5 commits into from
Oct 9, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Oct 8, 2024

StoryWPB-10539 [Android] Your Profile page - updated


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Designs were updated after syncing with the iOS platform

Causes (Optional)

  • We wanted to emphasize more the call to action of the button
  • New designs were adjusted

Solutions

Adjust the designs, to doing so, I fall back to the initial approach (before QR) and used constraint layout.

Attachments (Optional)

Before:

aa121

Now:

Screenshot 2024-10-08 at 07 23 13


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Oct 8, 2024
Copy link

sonarqubecloud bot commented Oct 8, 2024

Copy link
Contributor

github-actions bot commented Oct 8, 2024

Built wire-android-staging-compat-pr-3487.apk is available for download

Copy link
Contributor

github-actions bot commented Oct 8, 2024

Built wire-android-dev-debug-pr-3487.apk is available for download

@yamilmedina yamilmedina requested review from a team, typfel and damian-kaczmarek and removed request for a team October 8, 2024 13:52
@yamilmedina yamilmedina added this pull request to the merge queue Oct 8, 2024
Merged via the queue into develop with commit 0725cf5 Oct 9, 2024
16 checks passed
@yamilmedina yamilmedina deleted the fix/update-designs-qr branch October 9, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants