-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: status bar colour during theme change #WPB-11158 #3494
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3494 +/- ##
===========================================
- Coverage 44.43% 44.43% -0.01%
===========================================
Files 466 466
Lines 15744 15749 +5
Branches 2653 2653
===========================================
+ Hits 6996 6998 +2
- Misses 7991 7994 +3
Partials 757 757
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3494.apk is available for download |
Built wire-android-dev-debug-pr-3494.apk is available for download |
ThemeOption.DARK -> AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_YES) | ||
} | ||
} | ||
HandleThemeChanges(viewModel.globalAppState.themeOption) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good one 🍇
Quality Gate passedIssues Measures |
Built wire-android-staging-compat-pr-3494.apk is available for download |
Built wire-android-dev-debug-pr-3494.apk is available for download |
What's new in this PR?
Issues
If status bar had set color the color was overwritten by the night mode change. Now
Causes (Optional)
The night mode change was firing after status bar color change, overwriting the color.
Solutions
Now
CommonTopAppBar
listens to the theme changes so it can reapply the color. I tried do it on a higher level without adding this dependency but did not managed.I also plan to replaceEdit: not feasible at this timerememberSystemUiController
withActivity.enableEdgeToEdge
that was added to the androidx.activity in a separate PRHow to Test
Start a call to your device. Status bar should be coloured to green
Go to settings - appearance while call is in progress
Start changing the theme
Status bar still should be coloured after change
Attachments (Optional)
Before
before.mp4
After
after.mp4
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.