Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable autocorrect for all email text fields #WPB-11485 #3496

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

damian-kaczmarek
Copy link
Contributor

@damian-kaczmarek damian-kaczmarek commented Oct 10, 2024

BugWPB-11485 [Android] Autocorrect enabled on the email fields

Issues

When entering email in some fields (ie. signup) you text gets autocorrected. For example you type: “something.” you will get “Something.”.

Solutions

Added constants and asserts to prevent future errors of the same type.

Testing

Test Coverage (Optional)

How to Test

Affected email text fields on screens


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@damian-kaczmarek damian-kaczmarek self-assigned this Oct 10, 2024
@damian-kaczmarek damian-kaczmarek changed the title fix: disable autocorrect for all email text fields fix: disable autocorrect for all email text fields #WPB-11485 Oct 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.82%. Comparing base (8dfbb5c) to head (732c6e1).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3496   +/-   ##
========================================
  Coverage    44.82%   44.82%           
========================================
  Files          467      467           
  Lines        15773    15773           
  Branches      2654     2654           
========================================
  Hits          7071     7071           
  Misses        7944     7944           
  Partials       758      758           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dfbb5c...732c6e1. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3496.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3496.apk is available for download

@yamilmedina yamilmedina enabled auto-merge October 11, 2024 13:59
Copy link

@yamilmedina yamilmedina added this pull request to the merge queue Oct 11, 2024
Copy link
Contributor

Built wire-android-staging-compat-pr-3496.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3496.apk is available for download

Merged via the queue into develop with commit 7091769 Oct 11, 2024
11 of 12 checks passed
@yamilmedina yamilmedina deleted the fix/email-autocorrect-disabled branch October 11, 2024 14:57
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants