-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disable autocorrect for all email text fields #WPB-11485 #3496
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3496 +/- ##
========================================
Coverage 44.82% 44.82%
========================================
Files 467 467
Lines 15773 15773
Branches 2654 2654
========================================
Hits 7071 7071
Misses 7944 7944
Partials 758 758 Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3496.apk is available for download |
Built wire-android-dev-debug-pr-3496.apk is available for download |
Quality Gate passedIssues Measures |
Built wire-android-staging-compat-pr-3496.apk is available for download |
Built wire-android-dev-debug-pr-3496.apk is available for download |
Issues
When entering email in some fields (ie. signup) you text gets autocorrected. For example you type: “something.” you will get “Something.”.
Solutions
Added constants and asserts to prevent future errors of the same type.
Testing
Test Coverage (Optional)
How to Test
Affected email text fields on screens
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.