-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Draft message issue #WPB-11565 #3515
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3515 +/- ##
=====================================================
- Coverage 45.34% 45.30% -0.05%
=====================================================
Files 470 470
Lines 15689 15701 +12
Branches 2625 2627 +2
=====================================================
- Hits 7114 7113 -1
- Misses 7830 7843 +13
Partials 745 745
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3515.apk is available for download |
Built wire-android-dev-debug-pr-3515.apk is available for download |
Built wire-android-staging-compat-pr-3515.apk is available for download |
Built wire-android-dev-debug-pr-3515.apk is available for download |
app/src/main/kotlin/com/wire/android/ui/home/conversations/ConversationScreen.kt
Outdated
Show resolved
Hide resolved
…versationScreen.kt Co-authored-by: Mohamad Jaara <[email protected]>
Quality Gate passedIssues Measures |
Built wire-android-staging-compat-pr-3515.apk is available for download |
Co-authored-by: Jakub Żerko <[email protected]> Co-authored-by: Mohamad Jaara <[email protected]>
https://wearezeta.atlassian.net/browse/WPB-11565
What's new in this PR?
Issues
When we had draft message stored, we did not clear it up from local state when it was sent, resulting in the message returning after sending for example file
Solutions
We clear local state whenever we clear input, so that those are in sync
Testing
How to Test
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.