Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Draft message issue #WPB-11565 #3515

Merged
merged 6 commits into from
Oct 22, 2024

Conversation

m-zagorski
Copy link
Contributor

@m-zagorski m-zagorski commented Oct 16, 2024

BugWPB-11565 [Android] Draft message comes back after sending file

https://wearezeta.atlassian.net/browse/WPB-11565

What's new in this PR?

Issues

When we had draft message stored, we did not clear it up from local state when it was sent, resulting in the message returning after sending for example file

Solutions

We clear local state whenever we clear input, so that those are in sync

Testing

How to Test

  • Open conversation write message and leave conversation
  • Get back to conversation, send the draft message
  • Send file
  • Draft message is not coming back

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@m-zagorski m-zagorski requested review from Garzas and saleniuk October 16, 2024 05:22
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Oct 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 45.30%. Comparing base (9984c00) to head (ddc31f8).
Report is 8 commits behind head on release/candidate.

Files with missing lines Patch % Lines
...versations/messages/draft/MessageDraftViewModel.kt 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3515      +/-   ##
=====================================================
- Coverage              45.34%   45.30%   -0.05%     
=====================================================
  Files                    470      470              
  Lines                  15689    15701      +12     
  Branches                2625     2627       +2     
=====================================================
- Hits                    7114     7113       -1     
- Misses                  7830     7843      +13     
  Partials                 745      745              
Files with missing lines Coverage Δ
...essagecomposer/state/MessageComposerStateHolder.kt 66.66% <ø> (ø)
.../messagecomposer/state/MessageCompositionHolder.kt 28.31% <100.00%> (-0.62%) ⬇️
...versations/messages/draft/MessageDraftViewModel.kt 89.28% <0.00%> (-7.15%) ⬇️

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9984c00...ddc31f8. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3515.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3515.apk is available for download

Copy link
Contributor

Built wire-android-staging-compat-pr-3515.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3515.apk is available for download

@yamilmedina yamilmedina changed the base branch from develop to release/candidate October 16, 2024 11:02
@m-zagorski m-zagorski added this pull request to the merge queue Oct 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 17, 2024
Copy link

Copy link
Contributor

Built wire-android-staging-compat-pr-3515.apk is available for download

@m-zagorski m-zagorski added this pull request to the merge queue Oct 22, 2024
Merged via the queue into release/candidate with commit 07b9e6b Oct 22, 2024
12 of 13 checks passed
@m-zagorski m-zagorski deleted the fix/draft-message-issue branch October 22, 2024 10:53
github-actions bot pushed a commit that referenced this pull request Oct 22, 2024
Co-authored-by: Jakub Żerko <[email protected]>
Co-authored-by: Mohamad Jaara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants