Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Failed image message are not visible on chat #WPB-11035 #3516

Merged
merged 5 commits into from
Oct 22, 2024

Conversation

m-zagorski
Copy link
Contributor

@m-zagorski m-zagorski commented Oct 16, 2024

BugWPB-11035 [Android] No error displayed when sending imaged or gifs without internet being availble

https://wearezeta.atlassian.net/browse/WPB-11035

What's new in this PR?

Issues

When sending image message fails, it was not visible in chat at all, so we have seen on conversation screen that we sent image, but it was not there.

Solutions

While checking for missing image data from remote, we can also check if its our own message, it it is - its safe to display it in chat

Dependencies (Optional)

We also need this change for full experience: wireapp/kalium#3063

Needs releases with:

Testing

How to Test

  • Turn off internet
  • Send image
  • Image is present in chat with retry options

Attachments (Optional)

Screenshot_20241016_074020_Wire Beta


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@m-zagorski m-zagorski requested review from Garzas and saleniuk October 16, 2024 05:42
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Oct 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.30%. Comparing base (8ecd559) to head (d91682b).

Files with missing lines Patch % Lines
...wire/android/mapper/RegularMessageContentMapper.kt 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3516      +/-   ##
=====================================================
- Coverage              45.30%   45.30%   -0.01%     
=====================================================
  Files                    470      470              
  Lines                  15697    15697              
  Branches                2627     2627              
=====================================================
- Hits                    7112     7111       -1     
  Misses                  7840     7840              
- Partials                 745      746       +1     
Files with missing lines Coverage Δ
...wire/android/mapper/RegularMessageContentMapper.kt 18.95% <50.00%> (-0.66%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ecd559...d91682b. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3516.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3516.apk is available for download

@yamilmedina yamilmedina changed the base branch from develop to release/candidate October 16, 2024 11:01
Copy link

Copy link
Contributor

Built wire-android-staging-compat-pr-3516.apk is available for download

@m-zagorski m-zagorski added this pull request to the merge queue Oct 22, 2024
Merged via the queue into release/candidate with commit c2d3536 Oct 22, 2024
12 of 13 checks passed
@m-zagorski m-zagorski deleted the fix/failed-image-messages-not-visible branch October 22, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants