Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add icon and promo banner for f-droid client [WPB-11464] #3529

Merged
merged 2 commits into from
Oct 21, 2024
Merged

chore: add icon and promo banner for f-droid client [WPB-11464] #3529

merged 2 commits into from
Oct 21, 2024

Conversation

mnimac
Copy link
Member

@mnimac mnimac commented Oct 18, 2024 •
edited by github-actions bot
Loading

This PR was created due to F-Droid not displaying an icon at https://f-droid.org/packages/com.wire/ and in their client.

For more information looked at https://f-droid.org/en/docs/All_About_Descriptions_Graphics_and_Screenshots/#triple-t-structure

TaskWPB-11464 [Android] F-Droid Wire icon N/A

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

F-droid client not showing logo and banner images

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@mnimac mnimac added the size/XS label Oct 18, 2024
@mnimac mnimac requested a review from yamilmedina October 18, 2024 14:51
@mnimac mnimac self-assigned this Oct 18, 2024
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Oct 18, 2024
@MohamadJaara MohamadJaara changed the base branch from develop to release/candidate October 18, 2024 14:53
@pull-request-size Pull Request Size
Copy link

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

@MohamadJaara MohamadJaara changed the base branch from release/candidate to develop October 18, 2024 14:53
@mnimac mnimac requested review from a team, typfel, Garzas, damian-kaczmarek and mathias-niboulies and removed request for a team October 18, 2024 14:56
@MohamadJaara MohamadJaara requested review from ohassine and removed request for typfel, mathias-niboulies and yamilmedina October 18, 2024 15:01
@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3529.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3529.apk is available for download

yamilmedina
yamilmedina approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Just added a question, and we need to check in case a cherry-pick for RC is needed :D

...main/play/listings/en-US/graphics/feature-graphic/Logo with safe space black on white 2x.png Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: are the whitespaces intentional in the name ? Or can we standardize to camel case ?

@yamilmedina yamilmedina self-requested a review October 18, 2024 16:00
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3529.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3529.apk is available for download

@MohamadJaara MohamadJaara added this pull request to the merge queue Oct 21, 2024
Merged via the queue into develop with commit cc2e2fc Oct 21, 2024
12 checks passed
@MohamadJaara MohamadJaara deleted the chore/add-icon-and-promo-banner-for-f-droid-client branch October 21, 2024 08:00
MohamadJaara pushed a commit that referenced this pull request Nov 8, 2024
@mnimac @MohamadJaara
chore: add icon and promo banner for f-droid client [WPB-11464] (#3529)
e8b5148 
(cherry picked from commit cc2e2fc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitorhugods vitorhugods vitorhugods approved these changes

@MohamadJaara MohamadJaara MohamadJaara approved these changes

@Garzas Garzas Awaiting requested review from Garzas Garzas was automatically assigned from wireapp/android

@damian-kaczmarek damian-kaczmarek Awaiting requested review from damian-kaczmarek damian-kaczmarek was automatically assigned from wireapp/android

@ohassine ohassine Awaiting requested review from ohassine

@yamilmedina yamilmedina Awaiting requested review from yamilmedina

Assignees

@mnimac mnimac

Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mnimac @yamilmedina @MohamadJaara @vitorhugods