Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add accessibility string to OtherUserProfile and search participants [WPB-9784] #3531

Conversation

borichellow
Copy link
Contributor

@borichellow borichellow commented Oct 21, 2024

TaskWPB-9784 [Android] accessibility strings – Conversation details

What's new in this PR?

Second part of PR #3495
Was split just to make review easier.

Added accessibility strings to OtherUserProfile and SearchParticipants screens.

@borichellow borichellow self-assigned this Oct 21, 2024
Base automatically changed from feat/add_accessibility_string_to_conversation_details to release/candidate October 21, 2024 13:19
@pull-request-size pull-request-size bot added size/L and removed size/S labels Oct 21, 2024
@pull-request-size pull-request-size bot added size/S and removed size/L labels Oct 22, 2024
Copy link
Contributor

Built wire-android-staging-compat-pr-3531.apk is available for download

Copy link
Contributor

Built wire-android-staging-compat-pr-3531.apk is available for download

Copy link
Contributor

Built wire-android-staging-compat-pr-3531.apk is available for download

@borichellow borichellow changed the title feat: Add accessibility string to OtherUserProfile and search participants feat: Add accessibility string to OtherUserProfile and search participants [WPB-9784] Oct 23, 2024
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Oct 23, 2024
Copy link
Contributor

Built wire-android-staging-compat-pr-3531.apk is available for download

Copy link
Member

@MohamadJaara MohamadJaara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggestions about removing implicant behaviours

Copy link

Copy link
Contributor

Built wire-android-staging-compat-pr-3531.apk is available for download

@borichellow borichellow added this pull request to the merge queue Oct 25, 2024
Merged via the queue into release/candidate with commit 669d39a Oct 25, 2024
12 of 13 checks passed
@borichellow borichellow deleted the feat/add_accessibility_string_to_other_user_profile branch October 25, 2024 08:53
github-actions bot pushed a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants