-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
other: localize some strings for a custom build (WPB-11703) #3534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohassine
changed the title
fix: localize some strings for a custom build (WPB-11703)
feat: localize some strings for a custom build (WPB-11703)
Oct 21, 2024
ohassine
changed the title
feat: localize some strings for a custom build (WPB-11703)
other: localize some strings for a custom build (WPB-11703)
Oct 21, 2024
ohassine
requested review from
a team,
typfel,
borichellow,
vitorhugods,
mchenani and
saleniuk
and removed request for
a team
October 21, 2024 14:20
Garzas
approved these changes
Oct 21, 2024
Test Results863 tests 863 ✅ 12m 14s ⏱️ Results for commit 581c4ad. |
APKs built during tests are available here. Scroll down to Artifacts! |
MohamadJaara
approved these changes
Oct 21, 2024
Quality Gate passedIssues Measures |
APKs built during tests are available here. Scroll down to Artifacts! |
7 tasks
echoes-hq
bot
added
the
echoes: product-roadmap
Work aligned with the customer-announced roadmap, targeting a specific release date.
label
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
echoes: product-roadmap
Work aligned with the customer-announced roadmap, targeting a specific release date.
size/XS
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Some texts are not localized
Solutions
Move that to strings.xml file
Needs releases with:
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.