chore: Change user search name surname highlight logic #WPB-6536 #3545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes: unplanned
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3545 +/- ##
===========================================
- Coverage 45.31% 45.30% -0.02%
===========================================
Files 470 469 -1
Lines 15710 15714 +4
Branches 2629 2630 +1
===========================================
Hits 7119 7119
- Misses 7844 7847 +3
- Partials 747 748 +1 see 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
Built wire-android-staging-compat-pr-3545.apk is available for download |
|
Built wire-android-dev-debug-pr-3545.apk is available for download |
borichellow
approved these changes
Oct 23, 2024
app/src/main/kotlin/com/wire/android/ui/home/conversations/search/HighLightName.kt
Show resolved
Hide resolved
saleniuk
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-6536
What's new in this PR?
Issues
When we're searching for users, we were not highlighting
@Solutions
We take into considerations the prefix, and now queries with
@highlight properly. There is an edge case where our search for@matwould return results without@and we do not highlight anything, but I confirmed with Vina that it is fine in that case.Testing
How to Test
Search for users with
@and without, check if proper parts of name and surname are highlighted. In the task description there are also places where it shouldnt change after this changesPR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.