fix: Wrap persistent connection service in try Cherry-pick [WPB-11113] #3547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borichellow
requested review from
MohamadJaara,
vitorhugods,
Garzas and
damian-kaczmarek
borichellow
changed the title
echoes-hq
bot
added
the
echoes: unplanned
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3547 +/- ##
=====================================================
- Coverage 45.29% 45.24% -0.06%
=====================================================
Files 470 470
Lines 15701 15708 +7
Branches 2627 2627
=====================================================
- Hits 7112 7107 -5
- Misses 7843 7856 +13
+ Partials 746 745 -1
Continue to review full report in Codecov by Sentry.
|
|
Built wire-android-staging-compat-pr-3547.apk is available for download |
…service_in_try_cherry_pick
MohamadJaara
approved these changes
Oct 23, 2024
|
ohassine
approved these changes
Oct 23, 2024
|
Built wire-android-staging-compat-pr-3547.apk is available for download |
ohassine
deleted the
fix/wrap_persistant_connection_service_in_try_cherry_pick
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick for RC from develop PR
What's new in this PR?
Issues
crashes in PlayStore https://play.google.com/console/u/0/developers/7098984309886892484/app/4973241010395499500/vitals/crashes/76ed8eaea06144fa56bcc122f39cd8a0/details?days=28&versionCode=100020981
Causes (Optional)
this happens when PersistentConnection Service is killed by some reason and restarted by OS from background.
Solutions
Basically the issue is on Android side, for now google suggests try-catch workaround only
https://issuetracker.google.com/issues/307329994#comment86
Also I've updated
StartPersistentWebsocketIfNecessaryUseCaseto useServicesManagerfor starting Service instead of doing it directly. So we have 1 place where all the Services started from.