-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: strip metadata from profile pictures (WPB-11170) #3590
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3590 +/- ##
===========================================
+ Coverage 45.33% 45.99% +0.65%
===========================================
Files 472 472
Lines 15794 15948 +154
Branches 2632 2630 -2
===========================================
+ Hits 7160 7335 +175
+ Misses 7884 7855 -29
- Partials 750 758 +8
Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3590.apk is available for download |
Built wire-android-dev-debug-pr-3590.apk is available for download |
Built wire-android-staging-compat-pr-3590.apk is available for download |
Built wire-android-dev-debug-pr-3590.apk is available for download |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just one comment about logs 😄
Quality Gate passedIssues Measures |
Built wire-android-staging-compat-pr-3590.apk is available for download |
Built wire-android-dev-debug-pr-3590.apk is available for download |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Make sure that we don't upload Exif metadata to profile pictures.
Solutions
ExifHandler
, so we centralized in there,Exif
manipulation of imagesDependencies (Optional)
wireapp/kalium#3089
Needs releases with:
Testing
Test Coverage (Optional)
Attachments (Optional)
Original image
Screen.Recording.2024-11-04.at.17.34.00.mov
Uploading avatar:
Screen.Recording.2024-11-04.at.17.34.37.mov
Result uploaded image:
Screen.Recording.2024-11-04.at.17.39.22.mov
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.