Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable x86 support [WPB-11427] #3600

Merged
merged 5 commits into from
Nov 27, 2024

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Nov 7, 2024

StoryWPB-11427 [Android] drop support for x86


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

disable x86 support

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. label Nov 7, 2024
@MohamadJaara MohamadJaara added echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... and removed echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. labels Nov 26, 2024
Copy link
Contributor

Built wire-android-staging-compat-pr-3600.apk is available for download

@MohamadJaara MohamadJaara added this pull request to the merge queue Nov 27, 2024
Merged via the queue into release/candidate with commit 334b821 Nov 27, 2024
12 of 13 checks passed
@MohamadJaara MohamadJaara deleted the feat/disable-x86-support branch November 27, 2024 09:01
github-actions bot pushed a commit that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants