Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Track qr-code analytics #WPB-11679 🍒 (#3565) #3664

Merged

Conversation

m-zagorski
Copy link
Contributor

@m-zagorski m-zagorski commented Nov 26, 2024

TaskWPB-11679 [Android] Report on Countly - QR clicks

https://wearezeta.atlassian.net/browse/WPB-11679

What's new in this PR?

Issues

Add analytics tracking for qr-code


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Nov 26, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.35%. Comparing base (9a791bf) to head (e32b806).

Files with missing lines Patch % Lines
...id/ui/userprofile/self/SelfUserProfileViewModel.kt 66.66% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3664      +/-   ##
=====================================================
+ Coverage              45.34%   45.35%   +0.01%     
=====================================================
  Files                    471      471              
  Lines                  15842    15847       +5     
  Branches                2655     2656       +1     
=====================================================
+ Hits                    7184     7188       +4     
- Misses                  7885     7886       +1     
  Partials                 773      773              
Files with missing lines Coverage Δ
...e/android/ui/userprofile/qr/SelfQRCodeViewModel.kt 53.65% <100.00%> (+3.65%) ⬆️
...id/ui/userprofile/self/SelfUserProfileViewModel.kt 52.48% <66.66%> (-0.04%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a791bf...e32b806. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3664.apk is available for download

@yamilmedina yamilmedina added this pull request to the merge queue Nov 26, 2024
Merged via the queue into release/candidate with commit e0ceff4 Nov 26, 2024
13 of 14 checks passed
@yamilmedina yamilmedina deleted the feat/track-qr-code-analytics-cherry-pick branch November 26, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants