Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set Foreground Service Behavior IMMEDIATE (WPB-5512) #3666

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Nov 26, 2024

EpicWPB-5512 [Android] General Bugs


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

https://play.google.com/console/u/0/developers/7098984309886892484/app/4973241010395499500/vitals/crashes/ec5bed79dbf7ff1b118d8f89a9fa72f8/details?days=28&versionCode=100042652&isUserPerceived=true

Solution

Setting foreground Service Behavior to IMMEDIATE, to show the notification without any delay

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 45.32%. Comparing base (b5ec027) to head (b60c0b6).

Files with missing lines Patch % Lines
...re/android/notification/CallNotificationManager.kt 0.00% 2 Missing ⚠️
...ire/android/services/PersistentWebSocketService.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3666      +/-   ##
=====================================================
- Coverage              45.33%   45.32%   -0.01%     
=====================================================
  Files                    471      471              
  Lines                  15848    15851       +3     
  Branches                2656     2656              
=====================================================
  Hits                    7184     7184              
- Misses                  7891     7894       +3     
  Partials                 773      773              
Files with missing lines Coverage Δ
...ire/android/services/PersistentWebSocketService.kt 0.00% <0.00%> (ø)
...re/android/notification/CallNotificationManager.kt 45.66% <0.00%> (-0.54%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5ec027...b60c0b6. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3666.apk is available for download

@yamilmedina yamilmedina changed the title feat: set Foreground Service Behavior IMMEDIATE fix: set Foreground Service Behavior IMMEDIATE (WPB-5512) Nov 27, 2024
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Nov 27, 2024
@yamilmedina yamilmedina added this pull request to the merge queue Nov 27, 2024
Merged via the queue into release/candidate with commit 8e66a7b Nov 27, 2024
13 of 15 checks passed
@yamilmedina yamilmedina deleted the setForegroundServiceBehavior-service branch November 27, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants