fix: revert of #3670 (WPB-14433)

[yamilmedina]

WPB-14433 [Android] Crash after longtapping on a conversation and putting phone to sleep

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

We introduced by caching the images, a problem visible as well by federation being enabled this week.

Causes (Optional)

Image loader is cached, and tries to use federation for assets.

Solutions

Revert the PR #3670 and pick the fixes needed only (#3689)

Testing

Test Coverage (Optional)

• I have added automated test to this contribution

How to Test

Login with 2 accounts in different backends (staging and prod) and you should NOT have failed to load images.

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[pull-request-size]

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

[sonarqubecloud]

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.4% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 46.12546% with 146 lines in your changes missing coverage. Please review.

Project coverage is 45.31%. Comparing base (ec33458) to head (6e10256).
Report is 2 commits behind head on release/candidate.

Files with missing lines	Patch %	Lines
...e/android/ui/home/conversations/model/UIMessage.kt	43.85%	85 Missing and 11 partials ⚠️
...e/conversations/messages/item/SystemMessageItem.kt	0.00%	14 Missing and 2 partials ⚠️
...om/wire/android/util/ui/LocalizedStringResource.kt	6.66%	14 Missing ⚠️
...in/kotlin/com/wire/android/mapper/ContactMapper.kt	0.00%	4 Missing ⚠️
.../wire/android/mapper/SystemMessageContentMapper.kt	0.00%	3 Missing ⚠️
...tlin/com/wire/android/mapper/ConversationMapper.kt	0.00%	0 Missing and 2 partials ⚠️
...wire/android/mapper/RegularMessageContentMapper.kt	33.33%	2 Missing ⚠️
...lin/com/wire/android/mapper/UIParticipantMapper.kt	60.00%	2 Missing ⚠️
.../ui/home/conversationslist/model/BadgeEventType.kt	77.77%	2 Missing ⚠️
...com/wire/android/mapper/UICallParticipantMapper.kt	50.00%	0 Missing and 1 partial ⚠️
... and 4 more

Additional details and impacted files

@@                  Coverage Diff                  @@
##           release/candidate    #3700      +/-   ##
=====================================================
+ Coverage              44.91%   45.31%   +0.39%     
=====================================================
  Files                    472      471       -1     
  Lines                  15757    15852      +95     
  Branches                2694     2653      -41     
=====================================================
+ Hits                    7077     7183     +106     
+ Misses                  7924     7898      -26     
- Partials                 756      771      +15     

Files with missing lines	Coverage Δ
...in/kotlin/com/wire/android/mapper/MessageMapper.kt	61.16% <100.00%> (+0.38%)	⬆️
...tlin/com/wire/android/mapper/OtherAccountMapper.kt	85.71% <100.00%> (+2.38%)	⬆️
...c/main/kotlin/com/wire/android/model/ImageAsset.kt	100.00% <100.00%> (+16.00%)	⬆️
...in/kotlin/com/wire/android/model/UserAvatarData.kt	31.81% <ø> (+20.70%)	⬆️
...n/kotlin/com/wire/android/ui/home/HomeViewModel.kt	62.79% <100.00%> (+2.79%)	⬆️
...me/conversations/info/ConversationInfoViewModel.kt	82.19% <100.00%> (+0.24%)	⬆️
...oid/ui/home/conversations/model/UIQuotedMessage.kt	27.77% <100.00%> (-8.81%)	⬇️
...tions/usecase/GetConversationsFromSearchUseCase.kt	85.18% <100.00%> (+0.56%)	⬆️
...ome/conversationslist/ConversationListViewModel.kt	31.44% <100.00%> (+0.60%)	⬆️
...i/home/conversationslist/model/ConversationItem.kt	76.71% <ø> (+24.71%)	⬆️
... and 18 more

... and 1 file with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec33458...6e10256. Read the comment docs.

[github-actions]

Built wire-android-staging-compat-pr-3700.apk is available for download