Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update api version on startup [WPB-14730] 🍒 #3701

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 3, 2024

This PR was automatically cherry-picked based on the following PR:

Original PR description:


BugWPB-14730 [Android] Fetch api version on app startup


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • added update api version on app startup to resolve issue with updating flags right away not after 24h when on backend some flags has been changed

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch echoes/initiative: federation-wire-cloud Activate Federation with MLS on Wire Cloud size/XS labels Dec 3, 2024
Copy link

sonarqubecloud bot commented Dec 4, 2024

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.78%. Comparing base (674bc9e) to head (844a757).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3701   +/-   ##
========================================
  Coverage    45.77%   45.78%           
========================================
  Files          472      472           
  Lines        16024    16026    +2     
  Branches      2705     2705           
========================================
+ Hits          7335     7337    +2     
  Misses        7928     7928           
  Partials       761      761           
Files with missing lines Coverage Δ
...otlin/com/wire/android/ui/WireActivityViewModel.kt 71.33% <100.00%> (ø)
...otlin/com/wire/android/ui/home/AppSyncViewModel.kt 76.92% <100.00%> (+1.92%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 674bc9e...844a757. Read the comment docs.

Copy link
Contributor Author

github-actions bot commented Dec 4, 2024

Built wire-android-staging-compat-pr-3701.apk is available for download

Copy link
Contributor Author

github-actions bot commented Dec 4, 2024

Built wire-android-dev-debug-pr-3701.apk is available for download

@MohamadJaara MohamadJaara added this pull request to the merge queue Dec 4, 2024
Merged via the queue into develop with commit 38c2379 Dec 4, 2024
12 of 13 checks passed
@MohamadJaara MohamadJaara deleted the fix/update-api-version-on-startup-cherry-pick branch December 4, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch echoes/initiative: federation-wire-cloud Activate Federation with MLS on Wire Cloud size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants