Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: hide conversation favorite filter [WPB-14923] #3724

Merged
merged 3 commits into from
Dec 10, 2024
Merged

chore: hide conversation favorite filter [WPB-14923] #3724

merged 3 commits into from
Dec 10, 2024

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Dec 10, 2024 •
edited by github-actions bot
Loading

TaskWPB-14923 [Android] Disable favorites and folders for 4.10

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • hidden conversation favorite filter for 4.10 release
  • hidden add/remove from favorites for 4.10 release

@Garzas Garzas self-assigned this Dec 10, 2024
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Dec 10, 2024
@Garzas Garzas requested a review from ohassine December 10, 2024 14:40
@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3724.apk is available for download

@Garzas Garzas enabled auto-merge December 10, 2024 16:08
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Garzas Garzas added this pull request to the merge queue Dec 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3724.apk is available for download

Merged via the queue into release/candidate with commit 7602733 Dec 10, 2024
14 of 15 checks passed
@Garzas Garzas deleted the chore/hide-conversation-favorite-filter branch December 10, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saleniuk saleniuk saleniuk approved these changes

@vitorhugods vitorhugods vitorhugods approved these changes

@yamilmedina yamilmedina Awaiting requested review from yamilmedina

@ohassine ohassine Awaiting requested review from ohassine

Assignees

@Garzas Garzas

Labels
DO NOT CHERRY PICK echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Garzas @vitorhugods @saleniuk