-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add query profiling and cached paginated list [WPB-14826] #3726
feat: add query profiling and cached paginated list [WPB-14826] #3726
Conversation
…add-query-profiling-and-cached-conv-list # Conflicts: # kalium
@saleniuk looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
@saleniuk looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3726 +/- ##
===========================================
+ Coverage 45.58% 45.63% +0.05%
===========================================
Files 476 477 +1
Lines 16113 16134 +21
Branches 2736 2736
===========================================
+ Hits 7345 7363 +18
- Misses 8001 8004 +3
Partials 767 767
Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3726.apk is available for download |
Built wire-android-dev-debug-pr-3726.apk is available for download |
Built wire-android-staging-compat-pr-3726.apk is available for download |
Built wire-android-dev-debug-pr-3726.apk is available for download |
…add-query-profiling-and-cached-conv-list
Quality Gate passedIssues Measures |
Built wire-android-staging-compat-pr-3726.apk is available for download |
Built wire-android-dev-debug-pr-3726.apk is available for download |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Paginated conversation list is loading slowly when navigating back from conversation screen.
Solutions
Implement caching for the
PagingData
flow - there's a ready to use extension functioncachedIn
.Add a logic to enable or disable database profiling to have logs with query execution times if the user enabled logging (only for cipher db) - thanks to that we will be able to confirm or eliminate some queries as potential causes of slow loading of conversation list.
Dependencies (Optional)
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Open conversation and navigate back - list should be cached and appear faster on the screen.
Enable logging in the app and check logcat or logs collected in the file to make sure there are also logs with query execution times.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.