Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert highlight mentions while typing (WPB-1895) - RC #3728

Merged
merged 5 commits into from
Dec 11, 2024

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Dec 11, 2024

StoryWPB-1895 [Android] Highlight mentions in TextInputs when typing


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

After implementing the mention highlight feature using a different BasicTextField, we realized that this approach does not support rich content due to API limitation.

As a result, we have decided to prioritize GIF support instead and will be removing the mention feature.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

@echoes-hq echoes-hq bot added echoes: unplanned Any work item that isn’t part of the product or technical roadmap. echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. labels Dec 11, 2024
@ohassine ohassine requested review from a team, typfel, yamilmedina, borichellow, saleniuk and sergeibakhtiarov and removed request for a team December 11, 2024 14:44
@ohassine ohassine enabled auto-merge December 11, 2024 14:53
@ohassine ohassine added this pull request to the merge queue Dec 11, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 30.23256% with 30 lines in your changes missing coverage. Please review.

Project coverage is 45.67%. Comparing base (1f1e393) to head (e97a24f).

Files with missing lines Patch % Lines
.../messagecomposer/state/MessageCompositionHolder.kt 23.68% 29 Missing ⚠️
...mposer/state/MessageCompositionInputStateHolder.kt 80.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3728      +/-   ##
=====================================================
- Coverage              45.70%   45.67%   -0.03%     
=====================================================
  Files                    473      473              
  Lines                  16052    16049       -3     
  Branches                2713     2712       -1     
=====================================================
- Hits                    7336     7330       -6     
- Misses                  7955     7958       +3     
  Partials                 761      761              
Files with missing lines Coverage Δ
.../ui/home/messagecomposer/EnabledMessageComposer.kt 0.00% <ø> (ø)
...essagecomposer/state/MessageComposerStateHolder.kt 66.66% <ø> (ø)
...mposer/state/MessageCompositionInputStateHolder.kt 63.41% <80.00%> (ø)
.../messagecomposer/state/MessageCompositionHolder.kt 28.74% <23.68%> (-0.09%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f1e393...e97a24f. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3728.apk is available for download

auto-merge was automatically disabled December 11, 2024 15:16

Pull Request is not mergeable

Merged via the queue into release/candidate with commit b9294f9 Dec 11, 2024
16 of 17 checks passed
@ohassine ohassine deleted the revert-mention-while-typing-rc branch December 11, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants