-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: revert highlight mentions while typing (WPB-1895) - RC #3728
Conversation
Ups 🫰🟨This PR is too big. Please try to break it up into smaller PRs. |
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3728 +/- ##
=====================================================
- Coverage 45.70% 45.67% -0.03%
=====================================================
Files 473 473
Lines 16052 16049 -3
Branches 2713 2712 -1
=====================================================
- Hits 7336 7330 -6
- Misses 7955 7958 +3
Partials 761 761
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3728.apk is available for download |
Pull Request is not mergeable
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
After implementing the mention highlight feature using a different BasicTextField, we realized that this approach does not support rich content due to API limitation.
As a result, we have decided to prioritize GIF support instead and will be removing the mention feature.
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.