Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more debug information (WPB-14930) 🍒 #3729

Merged
merged 2 commits into from
Dec 15, 2024

Conversation

github-actions[bot]
Copy link
Contributor

This PR was automatically cherry-picked based on the following PR:

Original PR description:


TaskWPB-14930 [Android] Add more debug information to internal builds

https://wearezeta.atlassian.net/browse/WPB-14930


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

As a way to help us troubleshoot our own app, in moments like now (December 2024) when a couple of important milestones needs to be achieved (MLS, federation). We want to have more information on internal builds.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Testing

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch size/S labels Dec 11, 2024
@yamilmedina yamilmedina added this pull request to the merge queue Dec 13, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.70%. Comparing base (375b8ca) to head (e4dc5dd).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3729      +/-   ##
===========================================
+ Coverage    45.63%   45.70%   +0.06%     
===========================================
  Files          477      477              
  Lines        16134    16154      +20     
  Branches      2736     2739       +3     
===========================================
+ Hits          7363     7383      +20     
  Misses        8004     8004              
  Partials       767      767              
Files with missing lines Coverage Δ
...com/wire/android/ui/debug/DebugDataOptionsState.kt 100.00% <100.00%> (ø)
...wire/android/ui/debug/DebugDataOptionsViewModel.kt 55.30% <100.00%> (+6.60%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 375b8ca...e4dc5dd. Read the comment docs.

Copy link
Contributor Author

Built wire-android-staging-compat-pr-3729.apk is available for download

Copy link
Contributor Author

Built wire-android-dev-debug-pr-3729.apk is available for download

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 13, 2024
@vitorhugods vitorhugods added this pull request to the merge queue Dec 15, 2024
Merged via the queue into develop with commit 924475a Dec 15, 2024
12 of 13 checks passed
@vitorhugods vitorhugods deleted the feat/add-more-debug-info-cherry-pick branch December 15, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants