Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: wrong url when opening team management after migration - RC (WPB-14872) #3731

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Dec 11, 2024

TaskWPB-14872 [Android] Wrong URL when opening team management after migration from button


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  • The user is redirected to the production team management url, instead the the one related to the current environement.
  • We show team name instead of user name in last step.
  • We don't hide migration banner after migration is done

Solutions

  • Get team URL from database instead of using a static link from strings.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-requested a review December 11, 2024 18:56
Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! we just need to fix some lint issues

@ohassine ohassine enabled auto-merge December 12, 2024 08:38
@ohassine ohassine added this pull request to the merge queue Dec 12, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Project coverage is 45.76%. Comparing base (8d320d0) to head (01f8da9).

Files with missing lines Patch % Lines
...serprofile/teammigration/TeamMigrationViewModel.kt 78.57% 3 Missing ⚠️
...id/ui/userprofile/self/SelfUserProfileViewModel.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3731      +/-   ##
=====================================================
+ Coverage              45.74%   45.76%   +0.02%     
=====================================================
  Files                    473      473              
  Lines                  16069    16082      +13     
  Branches                2715     2715              
=====================================================
+ Hits                    7350     7360      +10     
- Misses                  7958     7962       +4     
+ Partials                 761      760       -1     
Files with missing lines Coverage Δ
...ui/userprofile/teammigration/TeamMigrationState.kt 100.00% <100.00%> (ø)
...id/ui/userprofile/self/SelfUserProfileViewModel.kt 56.29% <0.00%> (-0.64%) ⬇️
...serprofile/teammigration/TeamMigrationViewModel.kt 90.19% <78.57%> (-4.55%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d320d0...01f8da9. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3731.apk is available for download

Merged via the queue into release/candidate with commit 412a932 Dec 12, 2024
13 of 14 checks passed
@ohassine ohassine deleted the Wrong-URL-when-opening-team-management-after-migration-rc branch December 12, 2024 09:25
github-actions bot pushed a commit that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants