Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: countly general implementation fixes (WPB-14941) #3732

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Dec 11, 2024

TaskWPB-14941 [Android] Disable Countly Views temporarily


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Countly general fixes:

  • Remove usage of halt() function, this was causing crashes as the instance it was being cleared when a second user without consent was being logged in. The proper way to do it is by using following these instructions

  • Disable view tracking, we will renable in the future, added a feature flag for it.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

sonarcloud bot commented Dec 11, 2024

Copy link
Contributor

Built wire-android-staging-compat-pr-3732.apk is available for download

@yamilmedina yamilmedina changed the title fix: countly general implementation fixes (WPB-12164) (WPB-14941) fix: countly general implementation fixes (WPB-14941) Dec 11, 2024
@yamilmedina yamilmedina added this pull request to the merge queue Dec 11, 2024
Merged via the queue into release/candidate with commit 6c4f287 Dec 11, 2024
15 of 16 checks passed
@yamilmedina yamilmedina deleted the fix/disable-view-tracking-countly branch December 11, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants