Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: harden countly sdk integration (WPB-15007) #3735

Merged
merged 5 commits into from
Dec 12, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Dec 12, 2024

BugWPB-15007 [Android] Countly SDK integration hardening


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Fixes several crashes while interacting with the SDK.

Solutions

  • wrap calls to SDK and log fatal exceptions.
  • Use safe (?) nullable operator and doubt completely on the SDK about possible crashes.

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

Built wire-android-staging-compat-pr-3735.apk is available for download

Copy link
Contributor

@Garzas Garzas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Countly is a special one if it has it's own wrapRequest 😅

@yamilmedina yamilmedina added this pull request to the merge queue Dec 12, 2024
Copy link
Contributor

Built wire-android-staging-compat-pr-3735.apk is available for download

Merged via the queue into release/candidate with commit 8d320d0 Dec 12, 2024
14 of 15 checks passed
@yamilmedina yamilmedina deleted the fix/disable-view-tracking-countly branch December 12, 2024 08:15
yamilmedina added a commit that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants