Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add signature used by mls client (WPB-15040) #3740

Merged
merged 5 commits into from
Dec 13, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Dec 13, 2024

BugWPB-15040 [Android] Display cipher suite on MLS device details


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Displaying of the MLS signature of the client was not implemented.

Solutions

Add the info according to specs

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Get a MLS client and in device details, you should see this info.

Attachments (Optional)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this Dec 13, 2024
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Dec 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.74%. Comparing base (6e37dc8) to head (8f343f4).

Files with missing lines Patch % Lines
...roid/ui/settings/devices/DeviceDetailsViewModel.kt 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release/candidate    #3740   +/-   ##
==================================================
  Coverage              45.73%   45.74%           
==================================================
  Files                    473      473           
  Lines                  16088    16092    +4     
  Branches                2715     2716    +1     
==================================================
+ Hits                    7358     7361    +3     
  Misses                  7970     7970           
- Partials                 760      761    +1     
Files with missing lines Coverage Δ
...id/ui/settings/devices/model/DeviceDetailsState.kt 100.00% <100.00%> (ø)
...roid/ui/settings/devices/DeviceDetailsViewModel.kt 67.50% <66.66%> (-0.03%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e37dc8...8f343f4. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3740.apk is available for download

@yamilmedina yamilmedina added this pull request to the merge queue Dec 13, 2024
Copy link
Contributor

Built wire-android-staging-compat-pr-3740.apk is available for download

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Dec 13, 2024
@yamilmedina yamilmedina added this pull request to the merge queue Dec 13, 2024
Copy link
Contributor

Built wire-android-staging-compat-pr-3740.apk is available for download

Merged via the queue into release/candidate with commit 90282ea Dec 13, 2024
14 of 15 checks passed
@yamilmedina yamilmedina deleted the fix/show-ciphersuite-indevicedetails branch December 13, 2024 22:01
yamilmedina added a commit that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants