Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update Countly events for personal to team migration (WPB-11318) - RC #3741

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Dec 13, 2024

StoryWPB-11318 [Android] Report Metric of Personal User creating a team in Countly


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Acceptance criteria got updated by Product team, so I am adapting it to the new changes

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, m-zagorski, yamilmedina, MohamadJaara, vitorhugods, Garzas, borichellow and saleniuk and removed request for a team December 13, 2024 15:49
@ohassine ohassine changed the title feat: update Countly events for personal to team migration (WPB-11318) feat: update Countly events for personal to team migration (WPB-11318) - RC Dec 13, 2024
@ohassine ohassine enabled auto-merge December 13, 2024 16:07
@ohassine ohassine added this pull request to the merge queue Dec 13, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.

Project coverage is 45.73%. Comparing base (1c29218) to head (34b4c14).

Files with missing lines Patch % Lines
...serprofile/teammigration/TeamMigrationViewModel.kt 0.00% 8 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3741      +/-   ##
=====================================================
- Coverage              45.76%   45.73%   -0.03%     
=====================================================
  Files                    473      473              
  Lines                  16082    16088       +6     
  Branches                2715     2715              
=====================================================
- Hits                    7360     7358       -2     
- Misses                  7962     7970       +8     
  Partials                 760      760              
Files with missing lines Coverage Δ
...id/ui/userprofile/self/SelfUserProfileViewModel.kt 57.24% <100.00%> (+0.95%) ⬆️
...serprofile/teammigration/TeamMigrationViewModel.kt 75.92% <0.00%> (-14.28%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c29218...34b4c14. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3741.apk is available for download

Merged via the queue into release/candidate with commit 6e37dc8 Dec 13, 2024
14 of 15 checks passed
@ohassine ohassine deleted the countly-events branch December 13, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants