fix: non-paginated conversation list is not loading [WPB-15066] #3747
+8
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
On current 4.11 staging build, the conversation list is not loading at all after fresh install and fresh login.
Causes (Optional)
For non-paginated state,
conversationListState
is created by usingnotPaginatedConversationListState
but looks like it's using it as a value instead of using it as a state that can change and should then recompose.Solutions
Two separate states are not needed and can unnecessarily use resources, so merge them into a single one - for paginated just pass single value initially with the paginated flow, for non-patinated just update
conversationListState
directly.Also, added
backStackMode
to the navigation command log so that it's more clear what the command is supposed to do.Testing
How to Test
Use a build version that doesn't have
paginated_conversation_list_enabled
enabled (currently onlyinternal
andprod
have it enabled), fresh install, log in and open the app - it should load conversation list properly and not be stuck in loading state.PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.