Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: non-paginated conversation list is not loading [WPB-15066] #3747

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Dec 16, 2024

BugWPB-15066 [Android] Conversation list not loading after login


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

On current 4.11 staging build, the conversation list is not loading at all after fresh install and fresh login.

Causes (Optional)

For non-paginated state, conversationListState is created by using notPaginatedConversationListState but looks like it's using it as a value instead of using it as a state that can change and should then recompose.

Solutions

Two separate states are not needed and can unnecessarily use resources, so merge them into a single one - for paginated just pass single value initially with the paginated flow, for non-patinated just update conversationListState directly.
Also, added backStackMode to the navigation command log so that it's more clear what the command is supposed to do.

Testing

How to Test

Use a build version that doesn't have paginated_conversation_list_enabled enabled (currently only internal and prod have it enabled), fresh install, log in and open the app - it should load conversation list properly and not be stuck in loading state.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Dec 16, 2024
@saleniuk saleniuk requested review from Garzas, a team, m-zagorski, yamilmedina, ohassine and mathias-niboulies and removed request for a team December 16, 2024 14:38
@saleniuk saleniuk enabled auto-merge December 16, 2024 15:00
@saleniuk saleniuk added this pull request to the merge queue Dec 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 45.70%. Comparing base (7a53935) to head (1a14d1a).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...ome/conversationslist/ConversationListViewModel.kt 40.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3747      +/-   ##
===========================================
- Coverage    45.73%   45.70%   -0.03%     
===========================================
  Files          477      477              
  Lines        16186    16183       -3     
  Branches      2740     2741       +1     
===========================================
- Hits          7403     7397       -6     
- Misses        8016     8018       +2     
- Partials       767      768       +1     
Files with missing lines Coverage Δ
...ome/conversationslist/ConversationListViewModel.kt 32.66% <40.00%> (-0.81%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a53935...1a14d1a. Read the comment docs.

Merged via the queue into develop with commit 842aa6a Dec 16, 2024
12 of 14 checks passed
@saleniuk saleniuk deleted the fix/non-paginated-conversations-not-loading branch December 16, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants