Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle mls disabled error [WPB-15022] #3752

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Dec 17, 2024

BugWPB-15022 [Android] MLS client is created, but not registered once mls keys are available on the backend


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Cherry pick for #3745

@Garzas Garzas self-assigned this Dec 17, 2024
@echoes-hq echoes-hq bot added the echoes/initiative: federation-wire-cloud Activate Federation with MLS on Wire Cloud label Dec 17, 2024
@Garzas Garzas enabled auto-merge December 17, 2024 09:45
@Garzas Garzas added this pull request to the merge queue Dec 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 45.71%. Comparing base (8128377) to head (459f9b9).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...wire/android/ui/debug/DebugDataOptionsViewModel.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3752      +/-   ##
===========================================
- Coverage    45.71%   45.71%   -0.01%     
===========================================
  Files          477      477              
  Lines        16187    16189       +2     
  Branches      2742     2743       +1     
===========================================
  Hits          7400     7400              
- Misses        8018     8020       +2     
  Partials       769      769              
Files with missing lines Coverage Δ
...roid/ui/settings/devices/DeviceDetailsViewModel.kt 67.50% <100.00%> (ø)
...wire/android/ui/debug/DebugDataOptionsViewModel.kt 54.47% <0.00%> (-0.83%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8128377...459f9b9. Read the comment docs.

Merged via the queue into develop with commit 21ee4fc Dec 17, 2024
14 of 15 checks passed
@Garzas Garzas deleted the fix/handle-mls-disabled-error-cherry-pick branch December 17, 2024 10:28
Copy link
Contributor

Built wire-android-staging-compat-pr-3752.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3752.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/initiative: federation-wire-cloud Activate Federation with MLS on Wire Cloud size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants