feat: Track ended call segmentation [#WPB-14256] #3756
Conversation
echoes-hq
bot
added
the
echoes/initiative: product-metrics-in-countly
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3756 +/- ##
===========================================
+ Coverage 45.76% 45.78% +0.02%
===========================================
Files 477 477
Lines 16199 16206 +7
Branches 2744 2744
===========================================
+ Hits 7413 7420 +7
Misses 8017 8017
Partials 769 769
Continue to review full report in Codecov by Sentry.
|
|
Built wire-android-staging-compat-pr-3756.apk is available for download |
|
Built wire-android-dev-debug-pr-3756.apk is available for download |
| trackRecentlyEndedCall() | ||
| } | ||
|
|
||
| private fun trackRecentlyEndedCall() { |
There was a problem hiding this comment.
question: wouldn't be better to have it in WireApplication than WireActivity? I mean, we can have CallActivity started without WireActivity, then after ending that call it won't trigger this event, right? 🤔
There was a problem hiding this comment.
Good point, sure ! going to move it up, tomorrows morning
| return when (conversationDetails.conversationType) { | ||
| Conversation.Type.ONE_ON_ONE -> "one_to_one" | ||
| Conversation.Type.GROUP -> "group" | ||
| else -> "unknown" |
https://wearezeta.atlassian.net/browse/WPB-14256
What's new in this PR?
Issues
Missing tracking for ended call.
Solutions
Map
RecentlyEndedCallMetadatainto the analytics segmentation and send the event to countlyPR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.