-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: adjust to edge-to-edge, remove deprecated APIs [WPB-14903] #3790
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3790 +/- ##
===========================================
+ Coverage 45.80% 45.83% +0.03%
===========================================
Files 483 483
Lines 16513 16501 -12
Branches 2783 2779 -4
===========================================
Hits 7563 7563
+ Misses 8170 8158 -12
Partials 780 780
Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3790.apk is available for download |
Built wire-android-dev-debug-pr-3790.apk is available for download |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
In android 15 we have to adhere to new APIs for edge to edge.
Issues
Solutions
updateSystemBarIconsAppearance
responsible for changing this colorLaunchedEffect
whenThemeOption
changes asSideEffect
is created in that function already which does the jobHandleDraggableBottomSheetDialog
as right now with edge-to-edge it's always transparentsetDecorFitsSystemWindows
withenableEdgeToEdge
AnimatedVisibility
with colors transition to make changes smootherdelay
withdebounce
when call state changes, becausedelay
was just supposed to act like adebounce
, and add smaller one also for other states to prevent blinkingTesting
How to Test
Open the app and turn off network connection or start a call to change the top bar state.
Attachments (Optional)
edge-to-edge.mp4
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.