Battermann/more stern tests 2 (#3239)

wireapp · Apr 24, 2023 · 19d4d54 · 19d4d54
1 parent 58b249e
commit 19d4d54
Show file tree

Hide file tree

Showing 5 changed files with 239 additions and 162 deletions.
diff --git a/changelog.d/5-internal/pr-3239 b/changelog.d/5-internal/pr-3239
@@ -0,0 +1 @@
+More integration tests for stern/backoffice
diff --git a/tools/stern/src/Stern/API/Routes.hs b/tools/stern/src/Stern/API/Routes.hs
@@ -316,7 +316,7 @@ type SternAPI =
                :> Capture "tid" TeamId
                :> "search-visibility"
                :> ReqBody '[JSON] TeamSearchVisibility
-               :> Get '[JSON] NoContent
+               :> Put '[JSON] NoContent
            )
     :<|> Named "get-route-outlook-cal-config" (MkFeatureGetRoute OutlookCalIntegrationConfig)
     :<|> Named "put-route-outlook-cal-config" (MkFeaturePutRouteTrivialConfigNoTTL OutlookCalIntegrationConfig)

diff --git a/tools/stern/src/Stern/Intra.hs b/tools/stern/src/Stern/Intra.hs
@@ -549,6 +549,7 @@ setTeamFeatureFlag tid status = do
   case statusCode resp of
     200 -> pure ()
     404 -> throwE (mkError status404 "bad-upstream" "team doesnt exist")
+    403 -> throwE (mkError status403 "bad-upstream" "legal hold config cannot be changed")
     _ -> throwE (mkError status502 "bad-upstream" "bad response")
   where
     checkDaysLimit :: FeatureTTL -> Handler ()
@@ -592,6 +593,7 @@ setSearchVisibility tid typ = do
         )
   case statusCode resp of
     200 -> pure ()
+    204 -> pure ()
     403 ->
       throwE $
         mkError